Add an optional path for using dxilconv #2236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HansKristian-Work
force-pushed
the
dxilconv-optional
branch
8 times, most recently
from
d1d4dba to
4d89b76
Compare
Signed-off-by: Hans-Kristian Arntzen <[email protected]>
Uses the official dxbc-to-dxil converter instead. This is only relevant for local debug and test. Forcing DXIL paths enables more instrumentation and is useful for testing purposes. Keep it a build-type optional thing since we want to know 100% that official builds don't use the DLL by accident. We can never rely on this DLL being present anyway. Signed-off-by: Hans-Kristian Arntzen <[email protected]>
Signed-off-by: Hans-Kristian Arntzen <[email protected]>
Signed-off-by: Hans-Kristian Arntzen <[email protected]>
HansKristian-Work
force-pushed
the
dxilconv-optional
branch
from
4d89b76 to
0642eb6
Compare
doitsujin
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handy for certain debugging scenarios since we can take advantage of the instrumentation in dxil-spirv and the generated code is a little more sane than DXBC ...